]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
workspace: Minor clarification
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 23 Feb 2018 21:48:50 +0000 (22:48 +0100)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 11 Sep 2019 23:32:16 +0000 (23:32 +0000)
Code and comment were based on the old get_input_rect() and get_outer_rect()
method names that were changed to the more appropriate get_buffer_rect() and
get_frame_rect() a long time ago.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/713

js/ui/workspace.js

index b38a9428e8d2b334ba16f2b1447101098482ce65..a8f57fd173b0d1281b863fc1d86134eb05fbb10a 100644 (file)
@@ -57,17 +57,16 @@ class WindowCloneLayout extends Clutter.LayoutManager {
         // has an extra set of "padding" around it that we need to trim
         // down.
 
-        // The outer rect (from which we compute the bounding box)
-        // paradoxically is the smaller rectangle, containing the positions
-        // of the visible frame. The input rect contains everything,
-        // including the invisible border padding.
-        let inputRect = window.get_buffer_rect();
+        // The bounding box is based on the (visible) frame rect, while
+        // the buffer rect contains everything, including the invisible
+        // border padding.
+        let bufferRect = window.get_buffer_rect();
 
         let box = new Clutter.ActorBox();
 
-        box.set_origin(inputRect.x - this._boundingBox.x,
-                       inputRect.y - this._boundingBox.y);
-        box.set_size(inputRect.width, inputRect.height);
+        box.set_origin(bufferRect.x - this._boundingBox.x,
+                       bufferRect.y - this._boundingBox.y);
+        box.set_size(bufferRect.width, bufferRect.height);
 
         return box;
     }